fix(Profile): Added menu to remove profile image #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
requested review from
a team,
richard-ramos,
stefandunca,
anastasiyaig and
osmaczko
and removed request for
a team
igor-sirotin
force-pushed
the
fix/issue-5921
branch
from
febad28
to
72647e0
Compare
Jenkins Builds
|
igor-sirotin
changed the title
stefandunca
approved these changes
Aug 8, 2022
igor-sirotin
requested review from
borismelnik
and removed request for
borismelnik
|
@igor-sirotin I set up a profile image during onboarding and it did not appear in the settings, did u see that as well?
|
osmaczko
approved these changes
Aug 8, 2022
@anastasiyaig, Yeap, I've opened a separate issue for that: #6861 |
Just to jump in, it was working after I introduced keycard flow, so must be something recently changed. |
@saledjenic, Actually it hasn't been working for at least 2 monts already 🤦 |
anastasiyaig
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5921
What does the PR do
Affected areas
Profile settings
Screenshot of functionality (including design for comparison)
This doesn't actually have designs. I discuess with John to first implement it the way I see it, then decide if it's ok.
But I was reffering to this design: https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?node-id=1116%3A108254
2022-08-07.23.59.27.mov